-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail the run if publish thread pool times out #5578
Conversation
Signed-off-by: Ben Sherman <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Ben Sherman <[email protected]>
@pditommaso ready for review. It will fail the run if |
Would have not been simpler to throw an exception here and rely on the abort mechanism? |
Probably would be simpler. In that case the |
I think the
|
Signed-off-by: Ben Sherman <[email protected]>
Right, just wondering if |
Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
catch( TimeoutException e ) { | ||
final ignoreErrors = config.navigate('workflow.output.ignoreErrors', false) | ||
if( !ignoreErrors ) | ||
throw new AbortOperationException("Timed out while waiting to publish outputs") | ||
else | ||
log.warn e.message | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code still needed? It looks like you added it to the thread pool manager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 👉 00376aa
Close #5577