Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the run if publish thread pool times out #5578

Merged
merged 8 commits into from
Jan 23, 2025

Conversation

bentsherman
Copy link
Member

Close #5577

Signed-off-by: Ben Sherman <[email protected]>
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit b654bfb
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/6792091cf9984400088438d9

@bentsherman bentsherman marked this pull request as ready for review December 9, 2024 15:10
Signed-off-by: Ben Sherman <[email protected]>
@bentsherman
Copy link
Member Author

@pditommaso ready for review. It will fail the run if workflow.output.ignoreErrors is false and the finalizer or publish pool times out

@pditommaso
Copy link
Member

Would have not been simpler to throw an exception here and rely on the abort mechanism?

@bentsherman
Copy link
Member Author

Probably would be simpler. In that case the abort() would be called in the middle of destroy(), is that expected to work?

@pditommaso
Copy link
Member

I think the abort will be called implicitly by throwing an exception. see here

Signed-off-by: Ben Sherman <[email protected]>
@bentsherman
Copy link
Member Author

Right, just wondering if abort() has some implicit assumption that destroy() has not been called yet. But from the code it looks safe. Simplified things a bit

Signed-off-by: Ben Sherman <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
Signed-off-by: Paolo Di Tommaso <[email protected]>
@pditommaso pditommaso merged commit 5325e5a into master Jan 23, 2025
9 checks passed
@pditommaso pditommaso deleted the 5577-fail-on-publish-timeout branch January 23, 2025 09:28
Comment on lines +697 to +703
catch( TimeoutException e ) {
final ignoreErrors = config.navigate('workflow.output.ignoreErrors', false)
if( !ignoreErrors )
throw new AbortOperationException("Timed out while waiting to publish outputs")
else
log.warn e.message
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this code still needed? It looks like you added it to the thread pool manager

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👉 00376aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail the run if the publish thread pool times out
2 participants